Wrap rejected response, to stay in line with Axios API#90
Open
notpushkin wants to merge 1 commit intodevelopit:masterfrom
Open
Wrap rejected response, to stay in line with Axios API#90notpushkin wants to merge 1 commit intodevelopit:masterfrom
notpushkin wants to merge 1 commit intodevelopit:masterfrom
Conversation
quicoto
approved these changes
Jan 5, 2023
Owner
|
LGTM - I might try to refactor this to reject with an Error that has the |
Author
|
@developit Sorry for bothering – any updates on this? :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Axios returns a custom object when request status is not OK (https://github.com/axios/axios/#handling-errors):
Redaxios on the other hand throws the response directly, as pointed out in comment #48 (comment).
The easiest fix would be just to wrap the response in an object, but for better compatibility we could add some other fields.